Re: gmake check runs just 13 tests instead of 77

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Mr OCP" <mr_ocp(at)hotmail(dot)com>
Cc: pgsql-admin(at)postgresql(dot)org
Subject: Re: gmake check runs just 13 tests instead of 77
Date: 2002-11-13 16:44:12
Message-ID: 22958.1037205852@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin

"Mr OCP" <mr_ocp(at)hotmail(dot)com> writes:
> I am testing the beta 5 version of 7.3, by using make check under solaris 7
> and 8 and it runs just 13 tests as against 77 tests as indicated in the
> README.regression,

I believe this problem is now fixed --- the pg_regress script was
making an unportable assumption about the behavior of 'awk'. If you
want to try it, apply the attached patch.

regards, tom lane

*** src/test/regress/pg_regress.sh.orig Sat Oct 19 13:30:30 2002
--- src/test/regress/pg_regress.sh Wed Nov 13 11:40:23 2002
***************
*** 545,560 ****
formatted=`echo $1 | awk '{printf "%-20.20s", $1;}'`
$ECHO_N "test $formatted ... $ECHO_C"

! # use awk to properly output backslashes
! (echo "SET autocommit TO 'on';"; awk 'BEGIN {printf "\\set ECHO all\n"}'; cat "$inputdir/sql/$1.sql") |
$PSQL -d "$dbname" >"$outputdir/results/$1.out" 2>&1
else
# Start a parallel group
$ECHO_N "parallel group ($# tests): $ECHO_C"
for name do
(
! # use awk to properly output backslashes
! (echo "SET autocommit TO 'on';"; awk 'BEGIN {printf "\\set ECHO all\n"}'; cat "$inputdir/sql/$name.sql") |
$PSQL -d $dbname >"$outputdir/results/$name.out" 2>&1
$ECHO_N " $name$ECHO_C"
) &
--- 545,566 ----
formatted=`echo $1 | awk '{printf "%-20.20s", $1;}'`
$ECHO_N "test $formatted ... $ECHO_C"

! (cat <<EOF
! SET autocommit TO 'on';
! \\set ECHO all
! EOF
! cat "$inputdir/sql/$1.sql") | \
$PSQL -d "$dbname" >"$outputdir/results/$1.out" 2>&1
else
# Start a parallel group
$ECHO_N "parallel group ($# tests): $ECHO_C"
for name do
(
! (cat <<EOF
! SET autocommit TO 'on';
! \\set ECHO all
! EOF
! cat "$inputdir/sql/$name.sql") | \
$PSQL -d $dbname >"$outputdir/results/$name.out" 2>&1
$ECHO_N " $name$ECHO_C"
) &

In response to

Browse pgsql-admin by date

  From Date Subject
Next Message Warren Massengill 2002-11-13 16:54:36 7.3b download problem
Previous Message Mr OCP 2002-11-13 16:39:19 Re: gmake check runs just 13 tests instead of 77