From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Better testing coverage and unified coding for plpgsql loops |
Date: | 2018-01-03 19:37:02 |
Message-ID: | 22954.1515008222@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> I really think we should stick with the macro implementation, unless
>> somebody wants to do some actual investigation to prove that a
>> function implementation imposes negligible cost.
> I don't really care too much about the macro-or-function side of this,
> but if you wanted to improve debuggability avoiding the performance cost
> of a function call, you could use a static inline function, which is
> supposed (AFAIK) to have performance characteristics equivalent to those
> of a macro.
I'm not sure whether inlining the function can be relied on to get rid
of the side effects of taking rc's address. It wouldn't take all that
much work to establish the point, probably, but it's work I don't care
to put into it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Walter Cai | 2018-01-03 19:38:05 | Programmatically accessing selection predicates |
Previous Message | Vik Fearing | 2018-01-03 19:33:25 | Re: to_timestamp TZH and TZM format specifiers |