| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: MSVC buildfarm critters are not running modules' TAP tests |
| Date: | 2019-09-08 23:44:16 |
| Message-ID: | 22859.1567986256@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I think that it is a good idea to add in subdircheck an extra path to
> check after TAP tests and run optionally these on top of the normal
> regression tests. I have a couple of comments.
> Shouldn't we check after TAP_TESTS in the Makefile?
Yeah, perhaps, but I wasn't sure about how to do that easily.
Feel free to add it ...
> There is an argument to also check after isolation tests and run
> them.
Hm, yeah, if there are any such tests in those directories.
> The glob() part is a good idea in itself I think. Why not
> back-patching it? I could double-check it as well.
The whole thing should be back-patched into branches that have
any affected tests. (But, please, not till after beta4 is
tagged.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-09-09 00:43:06 | Re: MSVC buildfarm critters are not running modules' TAP tests |
| Previous Message | Andrew Dunstan | 2019-09-08 23:42:37 | Re: MSVC buildfarm critters are not running modules' TAP tests |