Re: Cause of recent buildfarm failures on hamerkop

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, harukat(at)sraoss(dot)co(dot)jp
Subject: Re: Cause of recent buildfarm failures on hamerkop
Date: 2012-09-14 21:53:05
Message-ID: 22840.1347659585@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Sep 14, 2012 at 7:02 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm not sure if we should just write this off as pilot error, or if we
>> should try to make the regression tests proof against such things. If
>> the latter, how exactly?

> I don't think we need to make them proof against it. But it wouldn't
> hurt to have a check that threw a predictable error when it happens.
> E.g. a first step in the regression tests that just verifies what kind
> of line endings are in a file. Could maybe be as simple as checking
> the size of the file?

Yeah, it would be easy to add a query that prints the large object's size
to the currently-failing test. That seems like a good idea
independently of whether we add a .gitattributes file as Aidan suggests.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-09-14 22:30:08 Re: Cause of recent buildfarm failures on hamerkop
Previous Message Tom Lane 2012-09-14 21:49:09 Re: Identity projection