Re: Add explicit casts in four places to simplehash.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Geier <geidav(dot)pg(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add explicit casts in four places to simplehash.h
Date: 2022-11-04 13:25:42
Message-ID: 2280953.1667568342@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Geier <geidav(dot)pg(at)gmail(dot)com> writes:
> On 11/3/22 15:50, Tom Lane wrote:
>> The bigger picture here is that we do actually endeavor to keep
>> (most of) our headers C++ clean, but our tool cpluspluscheck misses
>> these problems because it doesn't try to use these macros.
>> I wonder whether there is a way to do better.

> What about having a custom header alongside cpluspluscheck which
> references all macros we care about?

Can't see that that would help, because of the hand maintenance
required to make it useful.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Imseih (AWS), Sami 2022-11-04 13:27:34 Re: Add index scan progress to pg_stat_progress_vacuum
Previous Message Reid Thompson 2022-11-04 12:56:13 Re: Add tracking of backend memory allocated to pg_stat_activity