Re: [PATCH] Log crashed backend's query (activity string)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Log crashed backend's query (activity string)
Date: 2011-09-06 21:34:51
Message-ID: 22764.1315344891@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Marti Raudsepp <marti(at)juffo(dot)org> writes:
> This patch adds the backend's current running query to the "backend
> crash" message.

Sorry, this patch is entirely unacceptable. We cannot have the
postmaster's functioning depending on the contents of shared memory
still being valid ... most especially not when we know that somebody
just crashed, and could have corrupted the shared memory in arbitrary
ways. No, I don't think your attempts to validate the data are
adequate, nor do I believe they can be made adequate. And I doubt
that the goal is worth taking risks for.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-09-06 21:52:35 Re: timezone GUC
Previous Message Bruce Momjian 2011-09-06 21:33:12 pgpass comment suggestion