Re: Getting rid of regression test input/ and output/ files

Corey Huinker <corey(dot)huinker(at)gmail(dot)com> writes:
> I have a nitpick about the \getenv FOO FOO lines.
> It's a new function to everyone, and to anyone who hasn't seen the
> documentation it won't be immediately obvious which one is the ENV var and
> which one is the local var. Lowercasing the local var would be a way to
> reinforce which is which to the reader. It would also be consistent with
> var naming in the rest of the script.

Reasonable idea. Another thing I was wondering about was whether
to attach PG_ prefixes to the environment variable names, since
those are in a more-or-less global namespace. If we do that,
then a different method for distinguishing the psql variables
is to not prefix them.

regards, tom lane