Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Jim Cox <shakahshakah(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>
Subject: Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server
Date: 2010-02-24 02:46:14
Message-ID: 22696.1266979574@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Well, "trivial" and "correct" are entirely different things :-(.

> So you are saying if you run pg_restore on the SQL dump file, it doesn't
> pick up the version?

No, I'm saying it printed the wrong thing if you did pg_restore -v from
an archive file made by a different pg_dump version. I fixed it, but
this patch was *not* ready to commit.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Takahiro Itagaki 2010-02-24 02:51:07 Re: Directory fsync and other fun
Previous Message Tom Lane 2010-02-24 02:15:59 pgsql: Un-break pg_dump for the case of zero-column tables.