| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Paquier <michael(at)paquier(dot)xyz>, "jian(dot)long(at)i-soft(dot)com(dot)cn" <jian(dot)long(at)i-soft(dot)com(dot)cn>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is there a memory leak in commit 8561e48? |
| Date: | 2018-05-01 15:42:15 |
| Message-ID: | 22655.1525189335@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> The memory leak can be fixed by adding a pfree().
That seems like an odd way to approach this. Why not just remove the
reset of _SPI_stack and _SPI_stack_depth, so as to subtract code rather
than adding it --- that is, make it actually work like you mistakenly
thought it did? If we're going to keep the stack in TopMemoryContext,
there's no need to thrash it on every transaction.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-05-01 16:04:48 | Re: Patch missing from back branches |
| Previous Message | Tom Lane | 2018-05-01 15:33:35 | Re: stats_ext test fails with -DCATCACHE_FORCE_RELEASE |