| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Andreas Karlsson" <andreas(at)proxel(dot)se> |
| Subject: | Re: IANA timezone abbreviations versus timezone_abbreviations |
| Date: | 2025-01-10 00:13:08 |
| Message-ID: | 2265169.1736467988@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aleksander Alekseev <aleksander(at)timescale(dot)com> writes:
> I tested and reviewed the patch. It fixes the originally reported bug
> and looks good to me.
Thanks for looking at it! I'm not sure we have full consensus on
this yet, but at least there seem to be a majority in favor.
So here's a v2 with some loose ends cleaned up.
In 0001, I edited the docs more heavily in hopes of addressing
Jelte's concern about the docs being confusing. The code and
test changes are the same as before.
0002 is also the same as before.
0003 is new work that fixes the pg_timezone_abbrevs view so
that its output matches the new behavior.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Seek-zone-abbreviations-in-the-IANA-data-before-t.patch | text/x-diff | 18.6 KB |
| v2-0002-Improve-DecodeTimezoneAbbrev-s-caching-logic.patch | text/x-diff | 6.0 KB |
| v2-0003-Add-zone-derived-abbreviations-to-the-pg_timezone.patch | text/x-diff | 11.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-01-10 00:14:45 | Re: per backend WAL statistics |
| Previous Message | Tomas Vondra | 2025-01-09 23:59:29 | Re: Adjusting hash join memory limit to handle batch explosion |