From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Refactor dlopen() support |
Date: | 2018-09-07 21:13:11 |
Message-ID: | 22629.1536354791@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 07/09/2018 16:19, Tom Lane wrote:
>> Somehow or other, the changes you made in dfmgr.c's #include lines
>> have made it so that find_rendezvous_variable's local "bool found"
>> variable is actually of type _Bool (which is word-wide on these
>> machines).
> Ah because dlfcn.h includes stdbool.h. Hmm.
Yeah, and that's still true as of current macOS, it seems.
I can make the problem go away with the attached patch (borrowed from
similar code in plperl.h). It's kind of grotty but I'm not sure there's
a better way.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
undo-stdbool-damage-in-dfmgr.patch | text/x-diff | 564 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-07 22:05:14 | pgsql: Fix longstanding recursion hazard in sinval message processing. |
Previous Message | Michael Paquier | 2018-09-07 20:52:19 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2018-09-07 21:22:14 | Re: libpq stricter integer parsing |
Previous Message | Michael Paquier | 2018-09-07 20:56:46 | Re: libpq stricter integer parsing |