| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix bgworkers in EXEC_BACKEND |
| Date: | 2012-12-27 23:44:57 |
| Message-ID: | 22625.1356651897@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I am still worried about the following scenario in the EXEC_BACKEND case:
> 1) postmaster starts
> 2) reads config
> 3) executes _PG_init for shared_preload_libraries
> 4) library 'abc' gets config value 'abc.num_workers = 2' and registers as many workers
> 5) some time goes by, workers, backends start
> 6) abc.num_workers gets changed to 3, SIGHUP
This is broken whether it's EXEC_BACKEND or not: you don't get to change
anything that determines the number of workers post-startup.
num_workers should have been declared PGC_POSTMASTER.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-12-27 23:48:50 | Re: fix bgworkers in EXEC_BACKEND |
| Previous Message | Andres Freund | 2012-12-27 23:09:18 | Re: fix bgworkers in EXEC_BACKEND |