Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Fwd: Re: [pgsql-hackers-win32] Import from Linux to
Date: 2004-08-15 10:18:46
Message-ID: 2262.24.211.141.25.1092565126.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan said:
>
>
> Bruce Momjian wrote:
>
>>One issue is that pre-8.0, psql files were opened in Win32 text mode,
>>so we wouldn't have seen this bug on Win32, but we would on Linux.
>>Because we open them on Win32 now in binary mode so we see control-Z it
>>will show up on Win32 too.
>>
>>
>>
>
> true, *BUT*
>
> The patch is not platform-specific. It simply makes psql accept the
> same line endings on COPY FROM that the backend will accept - in
> effect it makes it line-end agnostic - this is a Good Thing (tm).
>
> We are still months away from releasing 8.0, so I think doing this for
> tomorrow's 7.4 bundle makes sense.
>

There's another question this bug raises, though. Why doesn't the server
protest when it sees more copy data passed in after it sees the end marker?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Sherry 2004-08-15 10:59:08 ALTER SCHEMA ... SET TABLESPACE
Previous Message Gavin Sherry 2004-08-15 07:43:44 Savepoint weirdness

Browse pgsql-patches by date

  From Date Subject
Next Message Gavin Sherry 2004-08-15 10:59:08 ALTER SCHEMA ... SET TABLESPACE
Previous Message Philip Warner 2004-08-15 07:00:02 Re: pg_dump 'die_on_errors'