Re: Clang function pointer type warnings in v14, v15

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Fri, Jul 12, 2024 at 2:26 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>>> I don't see any on clang 16 in the 12 and 13 branches. Where are you
>>> seeing them?

>> In the buildfarm. "adder" and a bunch of other machines are throwing
>> -Wcast-function-type in about two dozen places in v13, and "jay" is
>> emitting several hundred -Wdeprecated-non-prototype warnings.

> Ah, I see. A few animals running with -Wextra.

Oh, got it.

> I gess we have to decide if it's a matter for the tree, or for the
> people who add -Wextra, ie to decide if they want to filter that down
> a bit with some -Wno-XXX.

I think it's reasonable to say that if you add -Wextra then it's
up to you to deal with the results. If we were contemplating
enabling -Wextra as standard, then it'd be our problem --- but
nobody has proposed that AFAIR. In any case we'd surely not
add it now to near-dead branches.

regards, tom lane