Re: [RFC] Common object property boards

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kohei Kaigai <kohei(dot)kaigai(at)emea(dot)nec(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Common object property boards
Date: 2011-08-07 16:02:34
Message-ID: 22555.1312732954@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> writes:
> I'm under implementation of this code according to the suggestion.
> However, I'm not sure whether it is really portable way (at least, GCC accepts),
> and whether the interface is simpler than as Robert suggested at first.

> #define get_object_property_attnum_name(objtype) \
> ({ AttrNumber ____temp; \
> get_object_property((objtype), NULL, NULL, NULL, NULL, \
> &____temp, NULL, NULL); \
> ____temp; })

Blocks within expressions are a gcc-ism and will fail on any other
compiler, so you can't do it that way.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-08-07 17:47:49 Yes, WaitLatch is vulnerable to weak-memory-ordering bugs
Previous Message Wojciech Muła 2011-08-07 12:57:36 [PL/pgSQL] %TYPE and array declaration