Re: Function structure in formatting.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Function structure in formatting.c
Date: 2007-08-08 14:38:28
Message-ID: 225.1186583908@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> To my mind, it would make a lot more sense (and make hacking the file
> a lot easier) if the processing functions were split into to_char and
> from_char variants. I'm not sure what, if any, advantage is gleaned
> by having these functions combined.

Yeah, I never liked that approach either. I suppose the idea was to
keep the to- and from- code for each format code close together, but
it blurs what's going on to a much greater extent than that's worth.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-08-08 14:51:58 Re: RIP: Buildfarm member Baiji ??
Previous Message Omar Bettin 2007-08-08 14:22:58 Hello

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2007-08-08 16:07:11 Re: Function structure in formatting.c
Previous Message Brendan Jurd 2007-08-08 11:36:35 Function structure in formatting.c