| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Jeremy Drake <pgsql(at)jdrake(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-03-21 05:50:06 |
| Message-ID: | 22492.1174456206@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> * Comments like "/* get text type oid, too lazy to do it some other way
> */" do not exactly inspire confidence :)
Surely the code was just using the TEXTOID macro? If so, it does not
require a comment. If not, it should be fixed ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-03-21 05:57:30 | HOT WIP Patch - Version 5.0 |
| Previous Message | Dennis Bjorklund | 2007-03-21 04:34:39 | Re: Money type todos? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-03-21 06:12:55 | Re: patch adding new regexp functions |
| Previous Message | Pavan Deolasee | 2007-03-21 05:41:07 | HOT WIP Patch - Version 5.0 |