Re: pgAgent: C++ Port - Patch Review

From: Linreg <linreg(at)gmx(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAgent: C++ Port - Patch Review
Date: 2013-09-15 18:16:27
Message-ID: 2245391.nPH3ul8aAQ@wolfclan.ang.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,
>
> This change is unrelated to porting to pure C++, and needs to be
> discussed and (if acceptable) implemented as a separate patch. I'm not
> convinced it's an appropriate change at all - I certainly work with
> customer who do not use a connection pooler for various reasons, and
> rely on the pooler in the agent to prevent large numbers of
> connect/disconnect cycles, which amongst other things use resources
> unnecessarily, and can fill up audit logs.

A little addendum:
- connection pooling per Job is not a problem. This changes send i in the next
week.
- connection pooling of all jobs has no effect in your code. The function
clearconnection released connection-objects before it can be reused after one
mainloop cycle. I think. I may be wrong.
so connection pooling per Job should be enough. What do you mean.

Thomas Steffen

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-09-16 10:32:02 Re: pgAgent: C++ Port - Patch Review
Previous Message Dave Page 2013-09-15 15:02:03 Re: pgAgent: C++ Port - Patch Review