Re: Detection of IPC::Run presence in SSL TAP tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Detection of IPC::Run presence in SSL TAP tests
Date: 2017-06-15 19:57:44
Message-ID: 22438.1497556664@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Jun 13, 2017 at 11:14 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'd vote for removing this and adding a configure-time check that
>> insists on IPC::Run when --enable-tap-tests is given.

> There was a patch last year to do something like that:
> https://www.postgresql.org/message-id/56BDDC20.9020506@postgrespro.ru
> While Test::More is part of any standard installation, IPC::Run is
> not. FWIW, I still think that this is worth checking for. That's way
> better than having the TAP tests explode with a weird fatal failure
> where one needs to dig into the logs just to find out that the module
> is missing.

> Attached is an updated patch, with credit mainly going to Eugene
> Kazakov. I have run autoconf myself, I know that usually committers do
> that... Hope you don't mind.

Pushed, thanks. I grabbed the very latest copy of ax_prog_perl_modules
out of the GNU archives --- it's only cosmetically different, but we
might as well be au courant.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-15 20:17:17 Re: Detection of IPC::Run presence in SSL TAP tests
Previous Message Vladimir Sitnikov 2017-06-15 19:38:48 Приглашение: Re: [HACKERS] intermittent failures in Cygwin from select... - пт, 16 июнь 2017 09:00 - 10:00 (MSK) (pgsql-hackers@postgresql.org)