Re: Use of systable_beginscan_ordered in event trigger patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Use of systable_beginscan_ordered in event trigger patch
Date: 2012-12-12 00:33:32
Message-ID: 2243.1355272412@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> I don't remember that we fixed that case, I did attach a patch in the
> previous email, what do you think?

Yeah, I had forgotten about that loose end, but we definitely need
something of the sort. Committed with additional documentation.
(I put something in the CREATE EVENT TRIGGER ref page, but do we
need anything about it in chapter 37?)

BTW, is the example in the CREATE EVENT TRIGGER ref page meant as an
IQ test for unwary readers? You do know there are people who will
copy-and-paste just about any example that's put in front of them.
Perhaps we just want to make sure they internalize the advice about how
to get out of a broken-event-trigger situation.

Kidding aside, I think we need either a big WARNING, or a different
example.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Gould 2012-12-12 01:01:18 Strange errors from 9.2.1 and 9.2.2 (I hope I'm missing something obvious)
Previous Message Andres Freund 2012-12-11 23:58:25 Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader