| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Gradek <mike(at)busbud(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #13440: unaccent does not remove all diacritics |
| Date: | 2015-09-02 23:59:37 |
| Message-ID: | 22423.1441238377@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-09-02 19:33:00 -0400, Tom Lane wrote:
>> I think it would be good to have a discussion someplace more widely read
>> than the -bugs list. -hackers or -general would be the place to find
>> out if this sort of change is widely acceptable.
> I'm fine with doing that - but my impression from this thread was that
> the only thing we're unsure about is wether to backpatch this change?
> Weren't you pretty close to backpatching it?
No, not after someone pointed out that it could have strange side-effects
on full text search configurations that used unaccent. You'd stop being
able to find documents whenever your search term is stripped of accents
more thoroughly than before. That might be all right in a new major
release (if it documents that you might have to rebuild your FTS indexes
and derived tsvector columns). It's not all right in a minor release.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-09-03 00:06:15 | Re: BUG #13440: unaccent does not remove all diacritics |
| Previous Message | Andres Freund | 2015-09-02 23:54:35 | Re: BUG #13440: unaccent does not remove all diacritics |