| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - add \if support |
| Date: | 2018-03-22 14:44:21 |
| Message-ID: | 2241beca-1491-6e0d-b457-f593b24a255d@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you, pushed
Fabien COELHO wrote:
>
> Hello Teodor,
>
>> Patch seems usefull and commitable except comments in conditional.[ch]. I'd
>> like to top/header comment in each file more detailed and descriptive. As for
>> now it mentions only psql usage without explaining how it is basic or common.
>
> Indeed, it was not updated.
>
> I've fixed the file names and added a simple description at the beginning of the
> header file, and a one liner in the code file.
>
> Do you think that more is needed?
>
> The patch also needed a rebase after the hash function addition.
>
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-22 14:46:44 | Re: WIP: a way forward on bootstrap data |
| Previous Message | Tom Lane | 2018-03-22 14:40:48 | Re: WIP: a way forward on bootstrap data |