| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: includeifexists in configuration file |
| Date: | 2011-11-16 14:54:18 |
| Message-ID: | 22411.1321455258@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Euler Taveira de Oliveira <euler(at)timbira(dot)com> writes:
> On 16-11-2011 02:28, Greg Smith wrote:
>> By recent popular request in the ongoing discussion saga around merging the
>> recovery.conf, I've added an "includeifexists" directive to the
>> postgresql.conf in the attached patch.
> I'm not following the merging recovery.conf thread but isn't it worth emitting
> at least an WARNING message when the file does not exist?
> Something like
> WARNING: could not open configuration file "/foo/missing.conf", skipping
Minor note here: people keep thinking that WARNING > LOG with respect to
messages that can only go to the server log. This is not correct ...
LOG would be the right elevel to use.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-16 14:58:43 | Re: [PATCH] Unremovable tuple monitoring |
| Previous Message | Yeb Havinga | 2011-11-16 14:50:21 | Re: [PATCH] Unremovable tuple monitoring |