From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Khee Chin <kheechin(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: reloptions with a "namespace" |
Date: | 2009-04-03 20:59:58 |
Message-ID: | 22392.1238792398@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> ... but I don't really see that this buys much of anything. I think a
> better answer to this kind of problem would be
> + Assert(IsA(def, ReloptElem));
Well, that will help to make wrong-node-type mistakes more obvious (at
least if you're running an assert-enabled build). It does nothing to
*fix* the mistakes. And it does nothing to eliminate duplicate coding
for essentially redundant node types, which is bothering me as well.
I don't like any of the changes I see in define.c since 8.3 ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-04-03 21:02:03 | Re: a few crazy ideas about hash joins |
Previous Message | Tom Lane | 2009-04-03 20:48:51 | Re: reloptions with a "namespace" |