| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Increase of buffers usage count by bgwriter |
| Date: | 2005-10-27 17:09:12 |
| Message-ID: | 22389.1130432952@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> I found that bgwriter increments usage count of buffers when it writes
>> the buffers. I feel this behavior is strange, because the behavior of
>> bgwriter will affect buffer management strategy.
> I think it might be sufficient to not increment usage_count when
> UnpinBuffer's "trashOK" parameter is false --- that's what
> SyncOneBuffer passes, so it'd fix the issue for bgwriter activity,
> and arguably all the other call sites that pass false also don't
> want the count to increment.
I've committed a change along this line. Thanks for the suggestion!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-10-27 17:12:52 | Re: Ideas for easier debugging of backend problems |
| Previous Message | Josh Berkus | 2005-10-27 16:54:03 | Test settings in postgresql.conf.sample in beta4 |