| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Tommy Gildseth <tommy(dot)gildseth(at)usit(dot)uio(dot)no>, General Postgres Mailing List <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: Text search segmentation fault |
| Date: | 2009-01-29 16:50:22 |
| Message-ID: | 22358.1233247822@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> I really think he should just change all the "unsigned int" into "unsigned
> char" and not do the type punning with pointer casts. That's just evil.
Oh, I see. That would work too, but I don't really see that it's a huge
improvement.
What *would* be an improvement IMHO is to declare the pointer as
unsigned char * in the first place ;-). However, that might result
in having to introduce a lot of casts elsewhere ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Raymond O'Donnell | 2009-01-29 16:56:07 | Re: Full backup - pg_dumpall sufficient? |
| Previous Message | Gregory Stark | 2009-01-29 16:45:53 | Re: Text search segmentation fault |