Re: Add BF member koel-like indentation checks to SanityCheck CI

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tristan Partin <tristan(at)neon(dot)tech>, John Naylor <johncnaylorls(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add BF member koel-like indentation checks to SanityCheck CI
Date: 2024-01-09 22:27:38
Message-ID: 2235365.1704839258@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I think we need to do that, too, but the question is how. The best
> suggestion I've heard so far was to make it part of the build, or part
> of the test suite, so that if you don't do it, some part of what you
> were going to do anyway actually fails. That avoids making it an extra
> step that you have to remember separately. We have an absolutely
> insane number of things-you-must-always-remember-to-do.

I thought we had a consensus that there should be a way to enable
running it as part of check-world, or some related target. But
nobody's written that patch yet.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-01-09 22:31:59 Re: Built-in CTYPE provider
Previous Message Robert Haas 2024-01-09 22:18:36 Re: Commitfest 2024-01 first week update