From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pgsql: Add sql_drop event for event triggers |
Date: | 2013-04-27 22:55:10 |
Message-ID: | 22310.1367103310@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Yeah, I was just looking at the IfSupported variant. In the structure
>> I just suggested (separate ProcessSlowUtility function), we could make
>> that work by having switch cases for some statements in both functions,
> I've done it the way you propose here, and then in the Slow variant we
> have two set of cases again: those with some manual transactionnal
> behavior or some other code complexities, and the really simple ones.
I started to look at this patch. What in the world is the point of
dividing the "slow" function into two separate switches? Seems like
you might as well put all the cases in the first switch back into
standard_ProcessUtility.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2013-04-28 03:07:46 | pgsql: pg_dump: Improve message formatting |
Previous Message | Tom Lane | 2013-04-27 21:49:20 | pgsql: Incidental cleanup of matviews code. |
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2013-04-28 00:29:51 | Re: 9.3 Beta1 status report |
Previous Message | Simon Riggs | 2013-04-27 22:12:24 | Re: exactly what is COPY BOTH mode supposed to do in case of an error? |