From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WITH clause in CREATE STATISTICS |
Date: | 2017-04-20 22:13:17 |
Message-ID: | 22269.1492726397@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Simon just pointed out that having the WITH clause appear in the middle
> of the CREATE STATISTICS command looks odd; apparently somebody else
> already complained on list about the same. Other commands put the WITH
> clause at the end, so perhaps we should do likewise in the new command.
> Here's a patch to implement that. I verified that if I change
> qualified_name to qualified_name_list, bison does not complain about
> conflicts, so this new syntax should support extension to multiple
> relations without a problem.
Yeah, WITH is fully reserved, so as long as the clause looks like
WITH ( stuff... ) you're pretty much gonna be able to drop it
wherever you want.
> Discuss.
+1 for WITH at the end; the existing syntax looks weird to me too.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-04-20 23:23:28 | Re: Unportable implementation of background worker start |
Previous Message | Tom Lane | 2017-04-20 22:09:08 | Re: Removing select(2) based latch (was Unportable implementation of background worker start) |