Re: DSM robustness failure (was Re: Peripatus/failures)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: DSM robustness failure (was Re: Peripatus/failures)
Date: 2018-10-18 00:55:09
Message-ID: 22237.1539824109@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Larry Rosenman <ler(at)lerctr(dot)org> writes:
> On Wed, Oct 17, 2018 at 08:10:28PM -0400, Tom Lane wrote:
>> However, I'm still slightly interested in how it
>> was that that broke DSM so thoroughly ... I pulled down your version of
>> python2.7 and will see if that reproduces it.

> It was built on a previous alpha, so who knows what the differing
> compiler/libs/kernel/etc did. The options used did *NOT* change, just
> the userland used to compile it. (I.E. that package, running on
> ALPHA10 is what broke).

Hm. I forcibly installed your package over the regular one using
pkg add -f python27-2.7.15.txz
and rebuilt PG, and what I get is a failure in the plpython regression
test, but no crash. So I'm still confused.

*** /usr/home/tgl/pgsql/src/pl/plpython/expected/plpython_import.out Wed Oct 17 19:48:19 2018
--- /usr/home/tgl/pgsql/src/pl/plpython/results/plpython_import.out Wed Oct 17 20:50:22 2018
***************
*** 64,79 ****
-- test import and simple argument handling
--
SELECT import_test_one('sha hash of this string');
! import_test_one
! ------------------------------------------
! a04e23cb9b1a09cd1051a04a7c571aae0f90346c
! (1 row)
!
-- test import and tuple argument handling
--
select import_test_two(users) from users where fname = 'willem';
! import_test_two
! -------------------------------------------------------------------
! sha hash of willemdoe is 3cde6b574953b0ca937b4d76ebc40d534d910759
! (1 row)
!
--- 64,79 ----
-- test import and simple argument handling
--
SELECT import_test_one('sha hash of this string');
! ERROR: AttributeError: 'module' object has no attribute 'sha1'
! CONTEXT: Traceback (most recent call last):
! PL/Python function "import_test_one", line 3, in <module>
! digest = hashlib.sha1(p.encode("ascii"))
! PL/Python function "import_test_one"
-- test import and tuple argument handling
--
select import_test_two(users) from users where fname = 'willem';
! ERROR: AttributeError: 'module' object has no attribute 'sha1'
! CONTEXT: Traceback (most recent call last):
! PL/Python function "import_test_two", line 4, in <module>
! digest = hashlib.sha1(plain.encode("ascii"))
! PL/Python function "import_test_two"

======================================================================

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-10-18 01:00:11 Re: DSM robustness failure (was Re: Peripatus/failures)
Previous Message Larry Rosenman 2018-10-18 00:14:29 Re: DSM robustness failure (was Re: Peripatus/failures)