| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Mach <mach(dot)robert(at)gmail(dot)com> |
| Subject: | Re: Proposal: Integrity check |
| Date: | 2008-01-25 17:27:22 |
| Message-ID: | 2221.1201282042@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> I would like to make following modification:
> 1) Add ReadBuffer_noerror (recommend me better name) function which will
> accept damaged page without Error. This page will be marked as corrupted
> and when ReadBuffer will touch this page then it will be handled in
> standard way.
This seems like a pretty horrid idea. Bad pages shouldn't be allowed to
get into shared buffers in the first place. Why not have the checking
logic operate outside shared buffers?
> 3) Add PageHeaderIsValid check also for write operation
> In production it should catch problem with memory or software bugs. In
> development it should catch memory overwriting.
Is there any evidence whatsoever to demonstrate that this is worth the
cycles it will eat?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Decibel! | 2008-01-25 17:49:34 | Re: Truncate Triggers |
| Previous Message | Zdenek Kotala | 2008-01-25 16:56:34 | Proposal: Integrity check |