Re: Error handling (or lack of it) in RemovePgTempFilesInDir

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Dec 5, 2017 at 8:40 AM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> Belatedly, +1. The error hiding seemed a bit odd considering that we
>> were prepared to log "unexpected file found ...". I probably should
>> have questioned that instead of extending it monkey-see-monkey-do.

> Well, I am -1 on this change. The coding before commit 561885d that
> you have now pushed (timezone makes me answer later) was way more
> conservative and I honestly preferred it as *only* the next postmaster
> restart would remove remnant temp files which can cause potentially GB
> of data to stay around.

Uh ... I'm confused? That particular change only concerns whether we emit
a log message, not whether the action is attempted or succeeds.

regards, tom lane