From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Allow the identifier length to be increased via a configure option |
Date: | 2006-12-27 20:29:48 |
Message-ID: | 22139.1167251388@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Dhanaraj M wrote:
>> I am sending the patch for the following TODO item:
>> Allow the identifier length to be increased via a configure option
> You should use pg_config.h, not mangle postgres_ext.h like that. Or
> maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
> I wouldn't do that, really).
I'm wondering how this got into the TODO list. It seems rather
pointless, and likely to create client compatibility problems (if not,
why is NAMEDATALEN exported at all?)
A bigger problem with the proposed patch is that it makes it look like
you can set the identifier length to any random number; the restrictions
mentioned in postgres_ext.h aren't enforced or even displayed to the
user of configure.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Roman Kononov | 2006-12-27 20:43:04 | Re: [BUGS] BUG #2846: inconsistent and confusing handling of underflows, |
Previous Message | Roman Kononov | 2006-12-27 20:27:10 | Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling |
From | Date | Subject | |
---|---|---|---|
Next Message | Roman Kononov | 2006-12-27 20:43:04 | Re: [BUGS] BUG #2846: inconsistent and confusing handling of underflows, |
Previous Message | Roman Kononov | 2006-12-27 20:27:10 | Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling |