Re: wrapping in extended mode doesn't work well with default pager

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Emre Hasegeli <emre(at)hasegeli(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-05-12 14:42:12
Message-ID: 22089.1399905732@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Stark <stark(at)mit(dot)edu> writes:
> On Mon, May 12, 2014 at 2:12 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>> Hm, there was an off by one error earlier in some cases, maybe we
>> fixed it by breaking other case. Will investigate.

> Those spaces are coming from the ascii wrapping indicators. i.e. the periods in:

Ah. I wonder whether anyone will complain that the format changed?

> Apparently we used to print those with border=1 in normal mode but in
> expanded mode we left out the space for those on the outermost edges
> since there was no need for them. If we put them in for wrapped mode
> then we'll be inconsistent if we don't for nonwrapped mode though. And
> if we don't put them in for wrapped mode then there's no way to
> indicate wrapping versus newlines.

Barring anyone complaining that the format changed, I'd say the issue
is not that you added them but that the accounting for line length
fails to include them.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-05-12 15:01:59 Re: Proposal for CSN based snapshots
Previous Message Andres Freund 2014-05-12 14:41:12 Re: Proposal for CSN based snapshots