| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dead code in ps_status.c |
| Date: | 2023-02-16 05:34:00 |
| Message-ID: | 2203806.1676525640@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> Therefore I think it is safe to drop the PS_USE_PS_STRING and
> PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments
> and macro tests, and prune the defunct configure/meson probe.
Seems reasonable. Patch passes an eyeball check.
> I guess (defined(sun) && !defined(BSD)) || defined(__svr5__) could be
> changed to just defined(sun) (surely there are no other living
> SysV-derived systems, and I think non-BSD Sun probably meant "Solaris
> but not SunOS"), but I don't know so I didn't touch that.
Hm, is "defined(sun)" true on any live systems at all?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2023-02-16 05:35:13 | remove duplicate comment. |
| Previous Message | Michael Paquier | 2023-02-16 05:26:55 | Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy |