Re: pgsql: Fix deadlock hazard in CREATE INDEX CONCURRENTLY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix deadlock hazard in CREATE INDEX CONCURRENTLY
Date: 2018-01-03 19:16:07
Message-ID: 22036.1515006967@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> Meh. I'd rather have the more stable test going forward; I think
>> alternate expected-files too easily hide unexpected behavior. We could
>> try leaving 9.4/9.5 alone and see if it's true that it doesn't fail
>> there. If not, I wouldn't mind losing the test in those branches
>> --- it's mainly intended to catch future breakage, after all.

> Makes sense. Pushed to 9.6 and up.

Some of the buildfarm machines still don't like this. It looks
like the buildfarm script is only capturing the postmaster log
and not regression.diffs, making it hard to diagnose :-(

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-01-03 19:37:28 Re: pgsql: Fix deadlock hazard in CREATE INDEX CONCURRENTLY
Previous Message Tom Lane 2018-01-03 18:03:39 Re: pgsql: Add parallel-aware hash joins.