| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade vs user created range type extension |
| Date: | 2016-09-22 23:33:49 |
| Message-ID: | 22032.1474587229@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have just encountered an apparent bug in pg_upgrade (or possibly pg_dump).
Hmm, it sort of looks like pg_dump believes it should dump the range's
constructor function in binary-upgrade mode, while the backend is creating
the constructor function during CREATE TYPE anyway. But if that's the
case, upgrade of user-defined range types would never have worked ...
seems like we should have noticed before now.
If that diagnosis is correct, we should either change pg_dump to not
dump that function, or change CREATE TYPE AS RANGE to not auto-create
the constructor functions in binary-upgrade mode. The latter might be
more flexible in the long run.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2016-09-22 23:42:00 | Re: pg_upgrade vs user created range type extension |
| Previous Message | Thomas Munro | 2016-09-22 23:10:17 | Re: Tracking wait event for latches |