| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Update obsolete index scan TID comments. |
| Date: | 2024-05-17 10:00:00 |
| Message-ID: | 21c7267f-c27b-af5a-2c61-8777098587cb@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hello Peter,
12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.
I found one more obsolete comment mentioning xs_ctup:
/*
* For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
* a virtual tuple that does not have the ctid column, so we have
* to get the TID from xs_ctup.t_self.
*/
IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;
*current_tid = scan->xs_heaptid;
Maybe you would like to fix it too...
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-05-17 11:54:42 | pgsql: A few follow-up fixes for GUC name quoting |
| Previous Message | Peter Eisentraut | 2024-05-17 09:50:54 | pgsql: Revise GUC names quoting in messages again |