Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed
Date: 2023-04-05 23:19:48
Message-ID: 2194723.1680736788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Don't initialize page in {vm,fsm}_extend(), not needed

Various buildfarm members are complaining about under-braced
initializations added by this commit.

visibilitymap.c: In function \342\200\230vm_extend\342\200\231:
visibilitymap.c:625:2: warning: missing braces around initializer [-Wmissing-braces]
PGAlignedBlock pg = {0};
^
visibilitymap.c:625:2: warning: (near initialization for \342\200\230pg.data\342\200\231) [-Wmissing-braces]

freespace.c: In function \342\200\230fsm_extend\342\200\231:
freespace.c:611:2: warning: missing braces around initializer [-Wmissing-braces]
PGAlignedBlock pg = {0};
^
freespace.c:611:2: warning: (near initialization for \342\200\230pg.data\342\200\231) [-Wmissing-braces]

This is from buri, similar from curculio, dragonet, idiacanthus,
xenodermus, etc

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-04-05 23:34:02 Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed
Previous Message Daniel Gustafsson 2023-04-05 21:25:44 pgsql: Allow to use system CA pool for certificate verification