Re: Unnecessary global variable declared in xlog.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unnecessary global variable declared in xlog.c
Date: 2021-11-16 07:08:54
Message-ID: 2193235.1637046534@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote:
>> The attached patch moves the "LastRec" variable declaration inside
>> StartupXLOG() where it is supposed to be.

> Yes, reading through the code, your suggestion makes sense. I'll
> double-check and apply if there are no objections.

I think LastRec was originally referenced by multiple functions
in xlog.c. But it does look like it could be a local now.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-11-16 07:37:44 Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN
Previous Message Masahiko Sawada 2021-11-16 06:31:18 Re: Skipping logical replication transactions on subscriber side