Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Date: 2005-10-21 15:29:20
Message-ID: 21916.1129908560@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> This patch improves the win32 CHECK_FOR_INTERRUPTS() performance by
> testing if any unblocked signals are queued before check
> pgwin32_signal_event. This avoids an unnecessary system call.

http://archives.postgresql.org/pgsql-patches/2005-10/msg00191.php

This looks to me like a pretty important performance tweak for Windows.
Can any of the people who worked on the Windows signal implementation
look it over and confirm it's OK?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2005-10-21 15:43:05 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Previous Message Tom Lane 2005-10-21 14:33:23 Re: collector/autovacuum after crash (8.1beta3)

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2005-10-22 14:28:32 Re: small code cleanup - gettimeofday()
Previous Message Andrew Dunstan 2005-10-21 14:39:23 small code cleanup - gettimeofday()