| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Errands around AllocateDir() |
| Date: | 2017-12-05 01:46:51 |
| Message-ID: | 21908.1512438411@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Note I am +/-0 with exposing ReadDirExtended in back-branches, because
> there is no use for it yet there.
My thought is basically that we might end up back-patching some change
that needs that. Nothing I've done today requires it, but it seems like
a very harmless guard against future problems.
I am BTW wondering whether any of the other directory scan loops in
the backend ought to be converted from ReadDir to ReadDirExtended(LOG).
I'm just finishing up making ResetUnloggedRelations() go the other way,
because of the argument that failing to reset unlogged relations would
be a data corruption hazard. But there may well be other cases where
the best thing on balance is to log the problem and press on. With
the changes we've made today, it's a very easy fix to flip from one
behavior to the other.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-12-05 01:48:01 | Re: Add PGDLLIMPORT lines to some variables |
| Previous Message | Michael Paquier | 2017-12-05 01:45:27 | Re: Error handling (or lack of it) in RemovePgTempFilesInDir |