Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: zengman <zengman(at)halodbtech(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"
Date: 2024-11-20 17:06:45
Message-ID: 218610.1732122405@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"=?gb18030?B?emVuZ21hbg==?=" <zengman(at)halodbtech(dot)com> writes:
> Thanks for your guidance, you are right, I looked at your patch
> and combined it with the example to generate a new patch,
> which is really better.

I pushed the code fix, but I can't really convince myself that the
test case is worth the cycles it'd eat forevermore. If we had
a way to reach the situation where there's setops but not any of
the other clauses in a leaf query, perhaps that would be worth
checking ... but we don't. It's just belt-and-suspenders-too
programming.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-11-20 17:13:18 Re: Add a write_to_file member to PgStat_KindInfo
Previous Message Anthonin Bonnefoy 2024-11-20 17:03:12 Re: Consider pipeline implicit transaction as a transaction block