Re: pgsql: Suppress uninitialized-variable warning.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Suppress uninitialized-variable warning.
Date: 2011-01-23 18:36:31
Message-ID: 21859.1295807791@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sun, Jan 23, 2011 at 19:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Which compiler did that come out of? I don't think I saw it on any of
>>> the ones I tried..

>> gcc 4.4.5, standard on Fedora 13. I'm surprised that yours did not show
>> it, because the usage pattern looks beyond gcc's ability to prove safe.

> Interesting. I just make clean/make:ed it again to make sure, and it
> doesn't. And I'm on:
> gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5

[ scratches head... ] Maybe you are using different switches, perhaps
optimization higher than -O2?

But anyway, I think the project policy for such things is that we want
to suppress warnings when feasible on all common compilers, so the patch
is appropriate no matter what the specific reason for the difference is.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2011-01-23 18:41:34 Re: pgsql: Suppress uninitialized-variable warning.
Previous Message Simon Riggs 2011-01-23 18:27:12 Re: [COMMITTERS] pgsql: Only show pg_stat_replication details to superusers