Re: pg_dump -Fd and compression level

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Marc Mamin <M(dot)Mamin(at)intershop(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump -Fd and compression level
Date: 2015-07-25 18:45:24
Message-ID: 21822.1437849924@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 07/25/2015 01:52 PM, I wrote:
>> I propose to tighten pg_dump's rules so that only 0..9 are accepted as
>> arguments for -Z, and in compress_io.c:cfopen(), if compression is
>> equal to Z_DEFAULT_COMPRESSION, not add any explicit compression value
>> to the mode, thus using the zlib default.

> As per attached patch.
> Comments?

Looks OK to me. Thanks for fixing it!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc Mamin 2015-07-25 19:07:13 Re: pg_dump -Fd and compression level
Previous Message Josh Berkus 2015-07-25 18:39:15 Re: Anyone working on the TOAST items on the TODO list?