Andres Freund <andres(at)anarazel(dot)de> writes:
> Is there a reason not to just set p_hasTargetSRFs once towards the end
> of the function, instead of doing so for all the non-error cases?
Yes: it's not supposed to get set when the SRF is in FROM.
> I wonder if there should be a seperate expression type for
> the INSERT ... VALUES(exactly-one-row); since that behaves quite
> differently.
Perhaps. Or maybe we should just use EXPR_KIND_SELECT_TARGET for that?
regards, tom lane