Re: This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Oct 29, 2014 at 2:35 AM, rohtodeveloper <rohtodeveloper(at)outlook(dot)com>
>> That's because the odbc_fdw will also call the odbc driver.
>> The follow pictures explain the situation.

> Ah, right, I completely forgot this fdw. Yeah it may be worth renaming that
> in the odbc driver... Inoue-san, Saito-san, Heikki, thoughts about the
> simple patch attached? check_client_encoding is used to extract an encoding
> name from the connection settings. Perhaps we could do better than that.

It's totally unmaintainable to expect that no global names inside the
backend will ever accidentally match global names in loaded modules.
What we need to be thinking about is why the linker is resolving the name
wrong and how that can be fixed. I'm inclined to think that this report
indicates a poor choice of link options while building the ODBC library.

regards, tom lane