Re: message style for errcontext

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: message style for errcontext
Date: 2010-05-17 18:31:57
Message-ID: 21793.1274121117@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> We have in 9.0 plperl.c
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));

> Could we agree on a capitalization and punctuation scheme?

Instances of errcontext() elsewhere don't use either initcap or
terminating period. I think that's probably good to stick with,
but the message guidelines need to document that these messages
shouldn't follow the "full sentence" style.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-05-17 18:42:45 Re: message style for errcontext
Previous Message Jim Nasby 2010-05-17 18:21:38 Re: GUCs that need restart