Re: [BUGS] BUG #8335: trim() un-document behaviour

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: amutu(at)amutu(dot)com, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [BUGS] BUG #8335: trim() un-document behaviour
Date: 2013-08-12 17:55:08
Message-ID: 21732.1376330108@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Based on my research, I am now proposing a new, attached patch which
> eliminates comma in all places in TRIM,

This will break even more stuff than the last patch, ie, every single
stored rule or view that contains a TRIM function. You can *not*
eliminate, or mess with, the expr_list production, because that's what
dumping of these function calls relies on.

It's easily a dozen years too late to change this, Bruce. Please just
think about documenting the underlying functions, if you feel a need
to do anything here.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2013-08-12 18:18:01 Re: [BUGS] BUG #8335: trim() un-document behaviour
Previous Message Bruce Momjian 2013-08-12 14:11:44 Re: [BUGS] BUG #8335: trim() un-document behaviour

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-08-12 17:56:55 Re: killing pg_dump leaves backend process
Previous Message Magnus Hagander 2013-08-12 17:40:53 Re: pg_basebackup vs. Windows and tablespaces