Re: Using each rel as both outer and inner for JOIN_ANTI

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Emre Hasegeli <emre(at)hasegeli(dot)com>
Subject: Re: Using each rel as both outer and inner for JOIN_ANTI
Date: 2023-04-05 21:11:11
Message-ID: 2169798.1680729071@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Thanks for reminding. Attached is the rebased patch, with no other
> changes. I think the patch is ready for commit.

Pushed after a little further fooling with the comments. I also had
to rebase it over 11c2d6fdf (Parallel Hash Full Join). I think I did
that correctly, but it's not clear to me whether any of the existing
test cases are now doing parallelized hashed right antijoins. Might
be worth a little more testing.

I think that Alvaro's concern about incorrect cost estimates may be
misplaced. I couldn't find any obvious errors in the costing logic for
this, given that we concluded that the early-exit runtime logic cannot
apply. Also, when I try simply executing Richard's original test query
(in a non-JIT build), the runtimes I get line up quite well ... maybe
too well? ... with the cost estimates:

v15 HEAD w/patch Ratio

Cost estimate 173691.19 90875.33 0.52
Actual (best of 3) 514.200 ms 268.978 ms 0.52

I think the smaller differentials you guys were seeing were all about
EXPLAIN ANALYZE overhead.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-04-05 21:15:34 Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Previous Message Peter Geoghegan 2023-04-05 20:59:03 Re: Should vacuum process config file reload more often